Improve make_interpret test coverage; Define behaviour for non explicitly interpreted stateless grammar#49
Conversation
|
Hey! Thanks for the contribution. We no longer use the Once you've done so, we can take a look again at the PR. Thanks again! :) |
|
@ReubenJ I have changed the target branch |
|
The test additions look great, thanks! I'm not sure I understand the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 69.11% 76.09% +6.97%
==========================================
Files 3 3
Lines 204 205 +1
==========================================
+ Hits 141 156 +15
+ Misses 63 49 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
I have added extra tests to improve test coverage of make_interpreter.
While improving the test coverage of stateless interpreter, I noticed the fallback for non-explicitly supported stateless grammar was not calling emit_eval even though emit_eval has an implemented fallback for that scenario. I am not sure what should be the idea on how to handle this case. For now, I suggested to call emit_eval in the commit: 791c618